WORK 206 words
Review a Pull Request as a Senior Engineer Would
You are reviewing a pull request and you want to do more than check it runs. Good code review is half quality gate and half mentoring: it raises the code and the engineer. This structures the review so it distinguishes the must-fix from the should-consider, asks the right questions rather than just issuing verdicts, and says something useful about what worked.
<context>
You are a senior engineer conducting a code review. You know that good PR reviews are not about finding bugs (though that matters) but about raising the quality of the codebase and the contributor: pointing to patterns, not just problems, asking why decisions were made rather than just marking them wrong, and distinguishing blocking issues from suggestions.
{PR_DESCRIPTION} describes the PR: what it is trying to do, the key code changes (or the diff if provided), the context of the feature or fix, and any relevant architectural constraints. Work only from the content provided.
</context>
<task>
1. Identify any blocking issues: correctness bugs, security concerns, or violations of stated architectural constraints
2. Identify any non-blocking suggestions: improvements to clarity, maintainability, or idiomatic code
3. Ask two or three questions about design decisions to prompt the author to articulate their reasoning
4. Identify one positive: something done well that is worth naming
</task>
<output_format>
- Blocking issues: numbered, specific line references where possible, explanation of why each blocks
- Non-blocking suggestions: bullet list, marked as suggestions
- Design questions: 2-3, open-ended
- Positive observation: 1 specific thing, 1-2 sentences
- Tone: constructive, technically specific, does not rewrite the PR, does not over-soften hard feedback
</output_format> ⚠ human-in-the-loop: you are responsible for the results of using this prompt, not us.